Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that Session.headers needs to be set to a OrderedDict in Header Ordering docs #6475

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Specify that Session.headers needs to be set to a OrderedDict in Header Ordering docs #6475

merged 1 commit into from
Aug 12, 2023

Conversation

joren485
Copy link
Contributor

Description.

Small improvement to the docs: Session.headers (and not Session) should be set to an OrderedDict to preserve header order.

Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OrderedDict requirement is a bit redundant now with Python 3, but I don't think we've actually evaluated if we have any special logic around this. For now I think fixing the incorrect link is useful until we consider rewriting this.

Thanks @joren485!

@nateprewitt nateprewitt merged commit cb7fcd7 into psf:main Aug 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants